Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spark expressions in field mapping during Ingestion #1122

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 2, 2020

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

Instead of just map columns with different name - this PR allows to use expressions (spark style) to enable simple transformations of features during ingestion.
Example

fieldMapping = {
   "feature1": "cos(feature1)",
   "feature2": "feature2 / feature1"
}

Available functions: https://spark.apache.org/docs/2.3.1/api/sql/index.html

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@khorshuheng
Copy link
Collaborator

/test python-sdk-integration-test

@woop
Copy link
Member

woop commented Nov 2, 2020

/lgtm

@pyalex
Copy link
Collaborator Author

pyalex commented Nov 2, 2020

/test python-sdk-integration-test

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8d1326f into feast-dev:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants