Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadBalancerSourceRanges option for both serving and core #114

Merged
merged 1 commit into from
Jan 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion charts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ The following table lists the configurable parameters of the Feast chart and the
| `core.resources.limits.memory` | core memory limits | 2G |
| `core.resources.requests.cpu` | core cpu requested | 1 |
| `core.resources.requests.memory` | core memory requested | 2G |
| `core.service.extIPAdr` | external IP address for core, required so jobs on external runners can connect to core | nil |
| `core.service.extIPAdr` | Internal load balancer IP Address for core, required so jobs on external runners can connect to core | nil |
| `core.service.loadBalancerSourceRanges` | IP source ranges that will have access to core. If not set, will default to 0.0.0.0/0 | nil |
| `core.service.grpc.port` | core service exposed grpc port | 8433 |
| `core.service.grpc.targetPort` | core service target grpc port | 8433 |
| `core.service.http.port` | core service exposed http port | 80 |
Expand Down Expand Up @@ -101,6 +102,8 @@ The following table lists the configurable parameters of the Feast chart and the
| `serving.service.grpc.targetPort` | serving service target grpc port | 8433 |
| `serving.service.http.port` | serving service exposed http port | 80 |
| `serving.service.http.targetPort` | serving service target http port | 8080 |
| `serving.service.extIPAdr` | Internal load balancer IP Address for serving, required so jobs on external runners can connect to the service | nil |
| `serving.service.loadBalancerSourceRanges` | IP source ranges that will have access to serving. If not set, will default to 0.0.0.0/0 | nil |
| `serviceAccount.name` | service account secret name to mount to deployments | nil |
| `serviceAccount.key` | service account secret key to mount to deployments | nil |
| `statsd.host` | host of statsd daemon for job metrics to be sent to | nil |
Expand Down
Binary file modified charts/dist/feast-0.1.0.tgz
Binary file not shown.
6 changes: 3 additions & 3 deletions charts/dist/index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ entries:
feast:
- apiVersion: v1
appVersion: 0.1.0
created: 2019-01-23T15:59:57.223680331+08:00
created: 2019-01-29T17:38:41.064665659+08:00
description: A Helm chart to install Feast on kubernetes
digest: 1b392c4fa1e3b7cff7afb1dc635a248d86c0c05d8b02b6fc4e884c20f6a03ff2
digest: 099023ae667dd8129fbf72adf14732cf1f32af60784d694634ef4e1983957a5a
name: feast
urls:
- feast-0.1.0.tgz
version: 0.1.0
generated: 2019-01-23T15:59:57.222635289+08:00
generated: 2019-01-29T17:38:41.063588825+08:00
6 changes: 6 additions & 0 deletions charts/feast/templates/core-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ spec:
type: LoadBalancer
{{- if .Values.core.service.extIPAdr }}
loadBalancerIP: {{ .Values.core.service.extIPAdr }}
{{- if .Values.core.service.loadBalancerSourceRanges }}
loadBalancerSourceRanges:
{{- range .Values.core.service.loadBalancerSourceRanges }}
- {{ . }}
{{- end }}
{{- end }}
{{- end }}
ports:
- name: http
Expand Down
8 changes: 7 additions & 1 deletion charts/feast/templates/serving-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ spec:
type: LoadBalancer
{{- if .Values.serving.service.extIPAdr }}
loadBalancerIP: {{ .Values.serving.service.extIPAdr }}
{{- end}}
{{- if .Values.serving.service.loadBalancerSourceRanges }}
loadBalancerSourceRanges:
{{- range .Values.serving.service.loadBalancerSourceRanges }}
- {{ . }}
{{- end }}
{{- end }}
{{- end }}
ports:
- name: grpc
port: {{ .Values.serving.service.grpc.port }}
Expand Down