Add deadletter/read-from-source metrics to batch and stream ingestion #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
terryyylim
force-pushed
the
add-deadletter-metrics
branch
from
5f30541
to
b36ef12
Compare
pyalex
reviewed
Dec 10, 2020
| batchDF | ||
| .filter(!validator.checkAll) | ||
| .mapPartitions(iter => { |
There was a problem hiding this comment.
can we convert this lambda into method of DeadLetterMetrics
pyalex
reviewed
Dec 10, 2020
| batchDF | ||
| .filter(!validator.checkAll) | ||
| .mapPartitions(iter => { | ||
| val res = iter | ||
| .map(row => { |
There was a problem hiding this comment.
Do we really need to iterate over all rows instead of just increment metric once by iter.length?
pyalex
reviewed
Dec 10, 2020
spark/ingestion/src/main/scala/feast/ingestion/StreamingPipeline.scala
Outdated
Show resolved
Hide resolved
pyalex
reviewed
Dec 10, 2020
spark/ingestion/src/main/scala/feast/ingestion/stores/deadletters/DeadLetterMetrics.scala
Outdated
Show resolved
Hide resolved
pyalex
reviewed
Dec 10, 2020
spark/ingestion/src/main/scala/org/apache/spark/metrics/source/DeadLetterSinkMetricSource.scala
Outdated
Show resolved
Hide resolved
|
@terryyylim please add some testing |
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
force-pushed
the
add-deadletter-metrics
branch
from
58ebc52
to
372bd69
Compare
pyalex
changed the title
|
/test test-end-to-end-gcp |
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
|
/test test-end-to-end |
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
pyalex
approved these changes
Dec 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
There are several new metrics (reported by ingestion job) added:
Also few bugs fixed:
Some existing metrics were renamed to unify naming across all metrics.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: