-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI should work on python 3.6 #1237
Conversation
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test test-end-to-end-sparkop |
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
New changes are detected. LGTM label has been removed. |
@pyalex: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com
What this PR does / why we need it:
To guarantee compatibility with python 3.6 (as declared in our
setup.py
) this PR downgrades python version to 3.6 in CI docker image.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: