Add Feast Serving histogram metrics #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitos
reviewed
Dec 22, 2020
| .collect(Collectors.toSet()); | ||
| Metrics.requestFeatureTableCount | ||
| .labels(project) | ||
| .observe(Double.valueOf(featureTableRefs.size())); |
There was a problem hiding this comment.
nit: looks like you use featureTableRefs just for counting distinct strings, consider doing
long countDistinct = featureReferences.stream().map(...)
.distinct()
.count();
....
.observe(Double.valueOf(countDistinct));
pyalex
reviewed
Dec 23, 2020
| Counter.build() | ||
| public static final Histogram requestEntityCount = | ||
| Histogram.build() | ||
| .buckets(1, 2, 5, 10) |
There was a problem hiding this comment.
oh, there could be much more :)
Let's do 1, 2, 5, 10, 20, 50, 100, 200
pyalex
reviewed
Dec 23, 2020
|
|
||
| public static final Histogram requestFeatureCount = | ||
| Histogram.build() | ||
| .buckets(1, 2, 5, 10, 15, 20) |
There was a problem hiding this comment.
1, 2, 5, 10, 15, 20, 30, 50
pyalex
reviewed
Dec 23, 2020
|
|
||
| public static final Histogram requestFeatureTableCount = | ||
| Histogram.build() | ||
| .buckets(1, 2, 5, 10) |
pyalex
approved these changes
Dec 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
add-online-retrieval-metrics
branch
from
7182d88
to
b1f0e5c
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
add-online-retrieval-metrics
branch
from
f4cb648
to
130e58d
Compare
|
/retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
This PR adds histogram metrics for Feast serving, which would allow us to determine:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: