Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix historical test for azure #1262

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 8, 2021

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: fixes the historical test to support azure blob storage

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@woop
Copy link
Member

woop commented Jan 8, 2021

/lgtm

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jklegar, oavdeev
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar jklegar merged commit d8a3795 into feast-dev:master Jan 8, 2021
@jklegar jklegar deleted the jacob_fix_hist branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants