Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable user to provide spark job template as input for jobservice deployment #1285

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

khorshuheng
Copy link
Collaborator

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
Currently, there's no way for users to mount the spark job template on the jobservice pod. This PR enables the user to mount custom job template as configmap.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

New options for Jobservice helm chart: users are now able to mount custom spark job template as configmap.

@khorshuheng khorshuheng changed the title Enable user to provide spark job template as input for jobservice deployment (WIP) Enable user to provide spark job template as input for jobservice deployment Jan 25, 2021
…loyment

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@khorshuheng khorshuheng changed the title (WIP) Enable user to provide spark job template as input for jobservice deployment Enable user to provide spark job template as input for jobservice deployment Jan 25, 2021
@khorshuheng khorshuheng added the kind/feature New feature or request label Jan 25, 2021
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, oavdeev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng khorshuheng merged commit 232821d into feast-dev:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants