Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test #130

Closed
wants to merge 53 commits into from
Closed

Conversation

zhilingc
Copy link
Collaborator

More or less done, making the PR first. Added integration test that runs the following steps on argo:

  1. build cli
  2. provision infra with TF
  3. run pytest which:
    a. registers necessary specs
    b. runs job
    c. checks the output against expected values

currently the repository is pointing to my fork, will change over to the main repository when the changes are complete

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator Author

/hold

@tims
Copy link
Contributor

tims commented Feb 14, 2019

Can you add a short Integration Tests section to the testing/readme that describes the whole sequence in english?

And a part that points to where we should start if we want to add new integration tests?

@zhilingc
Copy link
Collaborator Author

Can you add a short Integration Tests section to the testing/readme that describes the whole sequence in english?

And a part that points to where we should start if we want to add new integration tests?

I've added some readmes but I'm in the process of figuring out a way of easily extending what's already there... any ideas?

zhilingc and others added 28 commits March 1, 2019 00:27
Fix to bucket accessible by the project running the integration test
Also ignore duplicate rows when retrieving actual test data result from warehouse so jobs can run multiple times on the same cluster and thes test still succeed
To customize the machine type for the node pools
@zhilingc zhilingc mentioned this pull request Mar 29, 2019
@zhilingc zhilingc closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants