Download BigQuery table to pyarrow table for python-based ingestion flow #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklegar
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
jklegar
commented
Mar 5, 2021
jklegar
commented
Mar 5, 2021
|
btw this is stacked on #1364 but I don't think GH PR's support stacked diffs |
woop
reviewed
Mar 5, 2021
woop
reviewed
Mar 5, 2021
sdk/python/feast/big_query_source.py
Outdated
| query: Optional[str], | ||
| ): | ||
| if (table_ref is None) == (query is None): | ||
| raise Exception("Exactly one of table_ref and query should be specified") |
There was a problem hiding this comment.
https://docs.python.org/3/library/exceptions.html#ValueError is preferred I think.
woop
reviewed
Mar 5, 2021
woop
reviewed
Mar 5, 2021
woop
reviewed
Mar 5, 2021
woop
reviewed
Mar 5, 2021
sdk/python/feast/offline_store.py
Outdated
|
|
||
| # if we have mapped fields, use the original field names in the call to BigQuery | ||
| event_timestamp_column = feature_view.inputs.event_timestamp_column | ||
| fields = ( |
There was a problem hiding this comment.
Can we please add a few comments to this code so that its easier for a reader to parse
woop
reviewed
Mar 7, 2021
jklegar
force-pushed
the
jacob_bq_tableref
branch
from
579074d
to
8bcd3ed
Compare
woop
reviewed
Mar 8, 2021
woop
reviewed
Mar 8, 2021
woop
reviewed
Mar 8, 2021
woop
requested changes
Mar 9, 2021
jklegar
force-pushed
the
jacob_bq_tableref
branch
from
35bccce
to
08bb0a2
Compare
jklegar
commented
Mar 10, 2021
woop
reviewed
Mar 11, 2021
woop
reviewed
Mar 11, 2021
sdk/python/feast/offline_store.py
Outdated
|
|
||
| class BigQueryOfflineStore(OfflineStore): | ||
| """ | ||
| BigQueryOfflineStore is a non-user-facing object used for all interaction between Feast and BigQuery. |
There was a problem hiding this comment.
I think we can maybe just leave out this comment and inherit from OfflineStore for now.
woop
reviewed
Mar 11, 2021
woop
reviewed
Mar 11, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
jklegar
force-pushed
the
jacob_bq_tableref
branch
from
47ee560
to
85465a1
Compare
|
/lgtm |
woop
approved these changes
Mar 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Implements downloading a BQ table to an in-memory pyarrow table, which will be part of the python-based ingestion flow
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: