Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in client archive_project method and fix lint in grpc auth #1396

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

randxie
Copy link
Contributor

@randxie randxie commented Mar 18, 2021

What this PR does / why we need it:

Fix bug in client.archive_project. It should use the core_service method instead of raw core_service_stub. Also fix lint in grpc/auth.py.

Does this PR introduce a user-facing change?:
NONE

Fix bug in client.archive_project and fix lint in grpc auth

@feast-ci-bot
Copy link
Collaborator

Hi @randxie. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Rand Xie <rand.xie@robinhood.com>
@woop woop changed the title fix a bug in client archive_project method and fix lint in grpc auth Fix a bug in client archive_project method and fix lint in grpc auth Mar 18, 2021
@woop
Copy link
Member

woop commented Mar 18, 2021

Thanks @randxie, remember to sign your commits please :)

@woop
Copy link
Member

woop commented Mar 18, 2021

/ok-to-test

Signed-off-by: Rand Xie <rand.xie@robinhood.com>
@woop
Copy link
Member

woop commented Mar 18, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randxie, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop added the kind/bug label Mar 18, 2021
@feast-ci-bot feast-ci-bot merged commit f9c99ca into feast-dev:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants