Pass entities information to Provider #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feast-ci-bot
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
needs-kind
size/S
size/M
and removed
size/S
labels
MattDelac
commented
Apr 23, 2021
MattDelac
changed the title
MattDelac
force-pushed
the
pass_entities_to_provider
branch
from
20fcf05
to
ad65d7a
Compare
woop
reviewed
Apr 23, 2021
MattDelac
force-pushed
the
pass_entities_to_provider
branch
from
ad65d7a
to
c771290
Compare
feast-ci-bot
added
release-note
and removed
do-not-merge/release-note-label-needed
labels
MattDelac
force-pushed
the
pass_entities_to_provider
branch
2 times, most recently
from
ce0a5bc
to
b39ccab
Compare
|
/ok-to-test |
woop
reviewed
Apr 23, 2021
MattDelac
force-pushed
the
pass_entities_to_provider
branch
from
b39ccab
to
c4fb5de
Compare
|
/kind housekeeping |
MattDelac
force-pushed
the
pass_entities_to_provider
branch
from
c4fb5de
to
be38436
Compare
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
MattDelac
force-pushed
the
pass_entities_to_provider
branch
from
be38436
to
33772cd
Compare
|
/retest |
woop
approved these changes
Apr 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MattDelac, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
woop
pushed a commit
that referenced
this pull request
Apr 27, 2021
Signed-off-by: Matt Delacour <matt.delacour@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some Providers would need the information about the entities to keep and to delete.
Therefore this PR aims to pass this information to the Provider object.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Not really as even if a user created a custom Provider, they could not use it (yet) because of the hard coded logic happening at the
get_providerfunction see reference)