Add opt-out exception logging telemetry #1535
Conversation
|
/kind housekeeping |
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
jklegar
force-pushed
the
jacob_exception_logging
branch
from
7ad1b33
to
8265940
Compare
| @@ -2,9 +2,9 @@ | |||
|
|
|||
| ## How telemetry is used | |||
|
|
|||
| The Feast maintainers use anonymous usage statistics to help shape the Feast roadmap. Several client methods are tracked, beginning in Feast 0.9. Users are assigned a UUID which is sent along with the name of the method, the Feast version, the OS \(using `sys.platform`\), and the current time. For more detailed information see [the source code](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/telemetry.py). | |||
| The Feast maintainers use anonymous usage statistics and error tracking to help shape the Feast roadmap. Several client methods are tracked, beginning in Feast 0.9. Users are assigned a UUID which is sent along with the name of the method, the Feast version, the OS \(using `sys.platform`\), and the current time. For more detailed information see [the source code](https://github.com/feast-dev/feast/blob/master/sdk/python/feast/telemetry.py). | |||
There was a problem hiding this comment.
@jklegar can we pull the Telemetry docs out of feast-on-kubernetes? What about creating a Telemetry page under Reference?
sdk/python/feast/telemetry.py
Outdated
| f.write(self._telemetry_id) | ||
| print( | ||
| "Feast is an open source project that collects anonymized error reporting and usage statistics. To opt out or learn" | ||
| " more see https://docs.feast.dev/v/master/feast-on-kubernetes/advanced-1/telemetry" |
There was a problem hiding this comment.
Same here, I think we should create a nicer URL. We also shouldnt point to master.
sdk/python/feast/telemetry.py
Outdated
| self._telemetry_enabled = False | ||
| self.check_env() | ||
|
|
||
| def check_env(self): |
There was a problem hiding this comment.
check is not an appropriate name if we are actually writing and initializing Telemetry.
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
- Coverage 83.72% 83.67% -0.05%
==========================================
Files 65 65
Lines 5634 5703 +69
==========================================
+ Hits 4717 4772 +55
- Misses 917 931 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add opt-out exception logging Signed-off-by: Jacob Klegar <jacob@tecton.ai> * lint Signed-off-by: Jacob Klegar <jacob@tecton.ai> * Update docs page Signed-off-by: Jacob Klegar <jacob@tecton.ai> * Use global Telemetry object Signed-off-by: Jacob Klegar <jacob@tecton.ai> * Address comments Signed-off-by: Jacob Klegar <jacob@tecton.ai>
What this PR does / why we need it: Telemetry will now log anonymized exceptions from Feast methods in addition to usage statistics
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: