Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx documentation building #1563

Merged
merged 2 commits into from
May 15, 2021
Merged

Conversation

woop
Copy link
Member

@woop woop commented May 15, 2021

What this PR does / why we need it:

Sphinx 4.0.0 breaks documentation building on master (also seen here datalad/datalad#5650). This PR prevents 4.0.0 from being used.

Does this PR introduce a user-facing change?:

NONE

woop added 2 commits May 15, 2021 12:03
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #1563 (6a85998) into master (1436a02) will decrease coverage by 6.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
- Coverage   83.81%   77.49%   -6.33%     
==========================================
  Files          65       64       -1     
  Lines        5628     5496     -132     
==========================================
- Hits         4717     4259     -458     
- Misses        911     1237     +326     
Flag Coverage Δ
integrationtests ?
unittests 77.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 32.11% <0.00%> (-62.05%) ⬇️
sdk/python/tests/fixtures/data_source_fixtures.py 38.88% <0.00%> (-61.12%) ⬇️
sdk/python/tests/test_cli_gcp.py 40.74% <0.00%> (-59.26%) ⬇️
sdk/python/tests/test_feature_store.py 60.52% <0.00%> (-39.48%) ⬇️
sdk/python/tests/test_historical_retrieval.py 63.09% <0.00%> (-35.72%) ⬇️
...hon/tests/test_offline_online_store_consistency.py 74.72% <0.00%> (-25.28%) ⬇️
sdk/python/feast/registry.py 58.77% <0.00%> (-20.18%) ⬇️
sdk/python/feast/infra/offline_stores/helpers.py 75.00% <0.00%> (-16.67%) ⬇️
sdk/python/feast/data_source.py 67.94% <0.00%> (-10.90%) ⬇️
sdk/python/feast/feature_view.py 81.25% <0.00%> (-6.25%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1436a02...6a85998. Read the comment docs.

@woop woop merged commit cfab265 into feast-dev:master May 15, 2021
woop added a commit that referenced this pull request May 19, 2021
* Fix broken documentation requirements

Signed-off-by: Willem Pienaar <git@willem.co>

* Prevent 4.0.0 of Sphinx from being used

Signed-off-by: Willem Pienaar <git@willem.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants