-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change OfflineStore class description #1571
Conversation
Signed-off-by: ted chang <htchang@us.ibm.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedhtchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
- Coverage 83.55% 77.36% -6.20%
==========================================
Files 65 64 -1
Lines 5754 5628 -126
==========================================
- Hits 4808 4354 -454
- Misses 946 1274 +328
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/ok-to-test |
@tedhtchang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: ted chang <htchang@us.ibm.com>
Signed-off-by: ted chang htchang@us.ibm.com
What this PR does / why we need it:
Both file and BigQuery are supported right ? Not only BigQuery.
Does this PR introduce a user-facing change?:
None