Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OfflineStore class description #1571

Merged
merged 1 commit into from
May 22, 2021

Conversation

tedhtchang
Copy link
Contributor

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Both file and BigQuery are supported right ? Not only BigQuery.

Does this PR introduce a user-facing change?:
None

None

Signed-off-by: ted chang <htchang@us.ibm.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedhtchang
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #1571 (a9e42c8) into master (14e4474) will decrease coverage by 6.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
- Coverage   83.55%   77.36%   -6.20%     
==========================================
  Files          65       64       -1     
  Lines        5754     5628     -126     
==========================================
- Hits         4808     4354     -454     
- Misses        946     1274     +328     
Flag Coverage Δ
integrationtests ?
unittests 77.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/feast/infra/offline_stores/offline_store.py 86.36% <ø> (ø)
sdk/python/tests/fixtures/data_source_fixtures.py 38.88% <0.00%> (-61.12%) ⬇️
sdk/python/tests/test_cli_gcp.py 40.74% <0.00%> (-59.26%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 32.41% <0.00%> (-58.63%) ⬇️
sdk/python/tests/test_feature_store.py 60.52% <0.00%> (-39.48%) ⬇️
sdk/python/tests/test_historical_retrieval.py 61.49% <0.00%> (-37.36%) ⬇️
...hon/tests/test_offline_online_store_consistency.py 74.72% <0.00%> (-25.28%) ⬇️
sdk/python/feast/registry.py 59.55% <0.00%> (-19.56%) ⬇️
sdk/python/feast/data_source.py 67.94% <0.00%> (-10.90%) ⬇️
sdk/python/feast/feature_view.py 81.63% <0.00%> (-6.13%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e4474...a9e42c8. Read the comment docs.

@woop
Copy link
Member

woop commented May 22, 2021

/ok-to-test

@woop woop merged commit d74bd80 into feast-dev:master May 22, 2021
@feast-ci-bot
Copy link
Collaborator

@tedhtchang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-telemetry a9e42c8 link /test test-telemetry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jklegar pushed a commit that referenced this pull request May 27, 2021
Signed-off-by: ted chang <htchang@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants