Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing historical retrieval assertion #1622

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

woop
Copy link
Member

@woop woop commented Jun 7, 2021

Signed-off-by: Willem Pienaar git@willem.co

What this PR does / why we need it:

Fixes failing e2e test

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #1622 (5cdea7f) into master (408a823) will increase coverage by 5.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
+ Coverage   77.84%   83.64%   +5.79%     
==========================================
  Files          66       67       +1     
  Lines        5688     5814     +126     
==========================================
+ Hits         4428     4863     +435     
+ Misses       1260      951     -309     
Flag Coverage Δ
integrationtests 83.53% <100.00%> (?)
unittests 77.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/test_historical_retrieval.py 98.85% <100.00%> (+37.35%) ⬆️
sdk/python/feast/infra/gcp.py 84.12% <0.00%> (ø)
sdk/python/feast/feature_store.py 91.85% <0.00%> (+0.45%) ⬆️
sdk/python/feast/repo_config.py 95.37% <0.00%> (+0.92%) ⬆️
sdk/python/feast/type_map.py 42.65% <0.00%> (+1.39%) ⬆️
sdk/python/feast/infra/provider.py 83.62% <0.00%> (+2.58%) ⬆️
sdk/python/tests/conftest.py 100.00% <0.00%> (+3.22%) ⬆️
sdk/python/feast/data_source.py 78.77% <0.00%> (+9.64%) ⬆️
sdk/python/feast/registry.py 79.11% <0.00%> (+19.55%) ⬆️
...hon/tests/test_offline_online_store_consistency.py 100.00% <0.00%> (+25.27%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408a823...5cdea7f. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit c961d31 into feast-dev:master Jun 7, 2021
tsotnet pushed a commit that referenced this pull request Jun 17, 2021
* Fix failing historical retrieval assertion

Signed-off-by: Willem Pienaar <git@willem.co>

* Ensure comments are accurate

Signed-off-by: Willem Pienaar <git@willem.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants