-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default feature naming to not include feature view name. Add option to include feature view name in feature naming. #1641
Conversation
Thanks for this @Mwad22! |
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
sdk/python/feast/feature_view.py
Outdated
@@ -182,6 +182,8 @@ def to_proto(self) -> FeatureViewProto: | |||
ttl_duration = Duration() | |||
ttl_duration.FromTimedelta(self.ttl) | |||
|
|||
print(f"Stream soruce: {self.stream_source}, {type(self.stream_source)}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed in #1678
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove and push, must have gotten added when I rebased.
Unfortunately @tsotnet's power is offline today. I will give the PR one final scan. |
…fault now set only in feature_store.py Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mwad22, this looks great to me. I had some super nitty things but happy to lgtm after they are addressed.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, Mwad22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nitpick changes Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>
Note, the unit tests that fail above are failing because of the following error:
They are not caused by the changes in this PR. |
/lgtm |
What this PR does / why we need it:
Provides a way to strip the
feature_view__
prefix from feature names during retrieval and reuse feature names directly from sources. This is done by adding afeature_names_only
arguments to the functions get_historical_features(), and get_online_features(). By default, we set this parameter to True, as that is what most users seem to prefer (per guidance given by @woop).Which issue(s) this PR fixes:
Fixes #1618
Does this PR introduce a user-facing change?:
Yes, the default behaviour of calling get_historical_features() and get_online_features() now return feature names that are stripped of the
feature_view__
prefix. This introduces the possibility of feature name collisions (in which case a descriptive error is thrown, informing users they can switch to the original behaviour by setting thefull_feature_names=True
in their retrieval function).