Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table_refs in BigQuerySource definitions #1644

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Jun 11, 2021

Signed-off-by: Tsotne Tabidze tsotne@tecton.ai

What this PR does / why we need it: I added a public dataset under feast-oss with 3 empty tables: drivers, customers, and customer_driver:
Screen Shot 2021-06-11 at 4 29 54 PM

Subsequently, I replaced all mentions of rh_prod.ride_hailing_co by feast-oss.public. This should unblock #1627.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #1644 (7039d0a) into master (e63737c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files          71       71           
  Lines        6113     6113           
=======================================
  Hits         5098     5098           
  Misses       1015     1015           
Flag Coverage Δ
integrationtests 83.31% <ø> (ø)
unittests 76.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/test_partial_apply.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63737c...7039d0a. Read the comment docs.

Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Jun 11, 2021
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
@woop
Copy link
Member

woop commented Jun 11, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit eef6b98 into feast-dev:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants