Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for supported sources for known online stores #1648

Closed
wants to merge 2 commits into from

Conversation

achals
Copy link
Member

@achals achals commented Jun 15, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Adds some assertions, and fixes some minor bugs with prints and removes a dangling reference to the redis provider.
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #1648 (c78ceda) into master (c63b037) will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   83.39%   83.46%   +0.06%     
==========================================
  Files          71       71              
  Lines        6113     6144      +31     
==========================================
+ Hits         5098     5128      +30     
- Misses       1015     1016       +1     
Flag Coverage Δ
integrationtests 83.39% <66.66%> (+0.07%) ⬆️
unittests 76.56% <66.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/helpers.py 79.41% <ø> (ø)
sdk/python/feast/repo_operations.py 32.35% <50.00%> (+0.17%) ⬆️
sdk/python/feast/repo_config.py 95.90% <100.00%> (ø)
sdk/python/feast/infra/online_stores/datastore.py 78.70% <0.00%> (-0.39%) ⬇️
sdk/python/tests/test_online_retrieval.py 100.00% <0.00%> (ø)
sdk/python/feast/online_response.py 97.43% <0.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63b037...c78ceda. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

@achals: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-telemetry c78ceda link /test test-telemetry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@achals
Copy link
Member Author

achals commented Jun 16, 2021

Closing this in favor of #1649

@achals achals closed this Jun 16, 2021
@achals achals deleted the achal/remove-redis-provider branch June 16, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants