Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel BigQuery job if block_until_done call times out or is interrupted #1699

Merged
merged 12 commits into from
Jul 14, 2021
Merged

Cancel BigQuery job if block_until_done call times out or is interrupted #1699

merged 12 commits into from
Jul 14, 2021

Commits on Jul 13, 2021

  1. Cancel job if to_bigquery is cancelled by user 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    f8420d8 View commit details
    Browse the repository at this point in the history

  2. cancel job in _upload_entity_df_into_bq as well 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    690828c View commit details
    Browse the repository at this point in the history

  3. Fix _is_done logic? 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    ad96114 View commit details
    Browse the repository at this point in the history

  4. make cancel job code more readable 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    c3d1b90 View commit details
    Browse the repository at this point in the history

  5. move KeyboardInterrupt catch outside retry logic; fix retry logic 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    c946079 View commit details
    Browse the repository at this point in the history

  6. make block_until_done public; add custom exception for BQJobStillRunning 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    1e7d852 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Merge branch 'master' of https://github.com/feast-dev/feast into canc… 

    …el-bq-job-on-keyboard-interrupt
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    47a3124 View commit details
    Browse the repository at this point in the history

  2. fix retry logic to catch specific exception 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6cfe938 View commit details
    Browse the repository at this point in the history

  3. Make retry params configurable; use finally clause to catch more canc… 

    …ellation cases

Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    786a634 View commit details
    Browse the repository at this point in the history

  4. Modify docstring 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    a6eb9a3 View commit details
    Browse the repository at this point in the history

  5. Typo in docstring 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    a6f6764 View commit details
    Browse the repository at this point in the history

  6. Fix lint 

    Signed-off-by: Cody Lin <codyl@twitter.com>
    Cody Lin committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    648937b View commit details
    Browse the repository at this point in the history