Clean up uploaded entities in Redshift offline store

[tsotnet]

Signed-off-by: Tsotne Tabidze tsotne@tecton.ai

What this PR does / why we need it: Currently uploaded Redshift entities are not cleaned up. They're left as random tables in Redshift. With this PR, the entities will not be uploaded during get_historical_features, but when you call to_X (e.g. to_df) on the returned RetrievalJob. At the same time, we'll clean up the uploaded entity table at the end of to_X call.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #1730 (bc45233) into master (489a0f8) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   79.08%   79.02%   -0.06%     
==========================================
  Files          80       80              
  Lines        6855     6895      +40     
==========================================
+ Hits         5421     5449      +28     
- Misses       1434     1446      +12     

Flag	Coverage Δ
integrationtests	78.95% <75.00%> (-0.06%)	⬇️
unittests	61.60% <8.33%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/infra/offline_stores/redshift.py	90.29% <72.72%> (-0.62%)	⬇️
sdk/python/feast/infra/utils/aws_utils.py	91.26% <100.00%> (ø)
...gration/offline_store/test_historical_retrieval.py	98.95% <100.00%> (ø)
sdk/python/feast/entity.py	73.98% <0.00%> (-2.60%)	⬇️
sdk/python/feast/feature_view.py	86.95% <0.00%> (-2.28%)	⬇️
sdk/python/feast/feature.py	75.00% <0.00%> (ø)
sdk/python/feast/feature_store.py	93.50% <0.00%> (ø)
sdk/python/feast/feature_service.py	71.21% <0.00%> (ø)
sdk/python/feast/inference.py	89.79% <0.00%> (+0.21%)	⬆️
sdk/python/feast/data_source.py	57.00% <0.00%> (+0.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489a0f8...bc45233. Read the comment docs.

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment