Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore feature refs #1746

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: #1691 allows for specifying FeatureServices in FeatureStore methods, but introduced a breaking change by renaming feature_refs to features. This PR ensures the change is not breaking, and inserts the appropriate DeprecationWarning.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Makes features an optional parameter in get_historical_features, instead of required

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…essary

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #1746 (3948acc) into master (2dfdace) will decrease coverage by 17.14%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1746       +/-   ##
===========================================
- Coverage   79.10%   61.95%   -17.15%     
===========================================
  Files          81       79        -2     
  Lines        6938     6855       -83     
===========================================
- Hits         5488     4247     -1241     
- Misses       1450     2608     +1158     
Flag Coverage Δ
integrationtests ?
unittests 61.95% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_feature_store.py 69.86% <ø> (-29.46%) ⬇️
sdk/python/feast/feature_store.py 91.00% <66.66%> (-2.64%) ⬇️
sdk/python/feast/feature_view.py 82.73% <100.00%> (-4.23%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 31.03% <0.00%> (-62.07%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dfdace...3948acc. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

@tedhtchang: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit de8a1b6 into feast-dev:master Jul 29, 2021
@felixwang9817 felixwang9817 deleted the restore_feature_refs branch July 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants