Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis to the universal integration tests #1784

Merged

Conversation

achals
Copy link
Member

@achals achals commented Aug 17, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1784 (4529733) into master (74c7bed) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
+ Coverage   85.15%   85.23%   +0.07%     
==========================================
  Files          87       87              
  Lines        6509     6522      +13     
==========================================
+ Hits         5543     5559      +16     
+ Misses        966      963       -3     
Flag Coverage Δ
integrationtests 85.15% <100.00%> (+0.04%) ⬆️
unittests 63.90% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tegration/feature_repos/test_repo_configuration.py 100.00% <100.00%> (ø)
.../tests/integration/scaffolding/test_repo_config.py 100.00% <0.00%> (ø)
sdk/python/feast/repo_config.py 92.96% <0.00%> (+0.34%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 93.10% <0.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c7bed...4529733. Read the comment docs.

@achals
Copy link
Member Author

achals commented Aug 17, 2021

/retest

@achals achals requested review from adchia and removed request for tsotnet and woop August 17, 2021 00:32
@adchia adchia self-assigned this Aug 17, 2021
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from adchia August 17, 2021 17:11
@adchia
Copy link
Collaborator

adchia commented Aug 17, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 90559fc into feast-dev:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants