Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Environment class and DataSourceCreator API, and use fixtures for datasets and data sources #1790

Merged
merged 53 commits into from
Sep 1, 2021
Merged

Refactor Environment class and DataSourceCreator API, and use fixtures for datasets and data sources #1790

merged 53 commits into from
Sep 1, 2021

Commits on Aug 18, 2021

  1. Fix API cruft from DataSourceCreator 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    789d7a1 View commit details
    Browse the repository at this point in the history

  2. Remove the need for get_prefixed_table_name 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    8b7eab5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. major refactor 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    0cc21ab View commit details
    Browse the repository at this point in the history

  2. move start time 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    6ddd5b0 View commit details
    Browse the repository at this point in the history

  3. Remove one dimension of variation to be added in later 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a700745 View commit details
    Browse the repository at this point in the history

  4. Fix default 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    c25b6cb View commit details
    Browse the repository at this point in the history

  5. Fixups 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a3e4473 View commit details
    Browse the repository at this point in the history

  6. Fixups 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    3f632fd View commit details
    Browse the repository at this point in the history

  7. Fix up tests 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    9aeea86 View commit details
    Browse the repository at this point in the history

  8. Add retries to execute_redshift_statement_async 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    84cbefd View commit details
    Browse the repository at this point in the history

  9. Add retries to execute_redshift_statement_async 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    fe180eb View commit details
    Browse the repository at this point in the history

  10. refactoooor 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    0cd08d2 View commit details
    Browse the repository at this point in the history

  11. remove retries 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    4701183 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Remove provider variation since they don't really play a big role 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    4cde284 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Session scoped cache for test datasets and skipping older tests whose… 

    … functionality is present in other universal tests

Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    974bb0b View commit details
    Browse the repository at this point in the history

  2. make format 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    dbbd6fb View commit details
    Browse the repository at this point in the history

  3. make format 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    473b630 View commit details
    Browse the repository at this point in the history

  4. remove import 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    95982e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. merge from master 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    fc1b4ee View commit details
    Browse the repository at this point in the history

  2. fix merge 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    df9596b View commit details
    Browse the repository at this point in the history

  3. Use an enum for the stopping procedure instead of the bools 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    fc46edb View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Fix refs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    0daaff0 View commit details
    Browse the repository at this point in the history

  2. fix step 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ef6a6b3 View commit details
    Browse the repository at this point in the history

  3. WIP fixes 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    d63691d View commit details
    Browse the repository at this point in the history

  4. Fix for feature inferencing 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    3d75977 View commit details
    Browse the repository at this point in the history

  5. C901 '_python_value_to_proto_value' is too complex :( 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    1abbaa8 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Split out construct_test_repo and construct_universal_test_repo 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    21996b7 View commit details
    Browse the repository at this point in the history

  2. remove import 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    4541561 View commit details
    Browse the repository at this point in the history

  3. add unsafe_hash 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2f20b5c View commit details
    Browse the repository at this point in the history

  4. Update testrepoconfig 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    6cc32b5 View commit details
    Browse the repository at this point in the history

  5. Update testrepoconfig 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    68f2997 View commit details
    Browse the repository at this point in the history

  6. Remove kwargs from construct_universal_test_environment 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a73868d View commit details
    Browse the repository at this point in the history

  7. Remove unneeded method 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    ff9d49d View commit details
    Browse the repository at this point in the history

  8. Docs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b95c3ee View commit details
    Browse the repository at this point in the history

  9. Kill skipped tests 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3e5aada View commit details
    Browse the repository at this point in the history

  10. reorder 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b6abcaa View commit details
    Browse the repository at this point in the history

  11. add todo 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    9580654 View commit details
    Browse the repository at this point in the history

  12. Split universal vs non data_source_cache 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    171a1ef View commit details
    Browse the repository at this point in the history

  13. make format 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    de9d8aa View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. WIP fixtures 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6454775 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. WIP Trying fixtures more effectively 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    3fbb2e4 View commit details
    Browse the repository at this point in the history

  2. fix refs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    2961d58 View commit details
    Browse the repository at this point in the history

  3. Fix refs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1739815 View commit details
    Browse the repository at this point in the history

  4. Fix refs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    fe14ba3 View commit details
    Browse the repository at this point in the history

  5. Fix refs 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    43d8e27 View commit details
    Browse the repository at this point in the history

  6. fix historical tests 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    58c75b0 View commit details
    Browse the repository at this point in the history

  7. renames 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8b5ba5a View commit details
    Browse the repository at this point in the history

  8. CR updates 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c445f53 View commit details
    Browse the repository at this point in the history

  9. use the actual ref to data source creators 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e0ccd9b View commit details
    Browse the repository at this point in the history

  10. merge from master 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4d4efad View commit details
    Browse the repository at this point in the history

  11. format 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    a510ca6 View commit details
    Browse the repository at this point in the history

  12. unused imports' 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6c10502 View commit details
    Browse the repository at this point in the history

  13. Add ids for pytest params 

    Signed-off-by: Achal Shah <achals@gmail.com>
    @achals
    achals committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ff1fb81 View commit details
    Browse the repository at this point in the history