-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable entityless featureviews #1804
Conversation
Hi @codyjlin. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
==========================================
+ Coverage 84.13% 84.51% +0.38%
==========================================
Files 90 90
Lines 6770 6827 +57
==========================================
+ Hits 5696 5770 +74
+ Misses 1074 1057 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind feature |
Signed-off-by: Cody Lin <codyl@twitter.com>
Signed-off-by: Cody Lin <codyl@twitter.com>
Signed-off-by: Cody Lin <codyl@twitter.com>
Signed-off-by: Cody Lin <codyl@twitter.com>
Signed-off-by: Cody Lin <codyl@twitter.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, codyjlin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cody Lin codyl@twitter.com
What this PR does / why we need it:
This PR executes on the Entityless FeatureViews RFC, with minor adjustments to Implementation 1:
__entityless
entity on every applyregistry_dump
(namely,list_entities
andlist_featureviews
)__entityless_id
dummy column to join on a constant value, and then having to hide it later when selecting columns)__entityless_id
column as empty string upon materialize (namely,pull_latest_from_table_or_query
in each offline store provider)get_online_features
requests any features from an entityless FV,{"__entityless_id": ""}
will be ajoin_key_row
to be converted to aentity_row_proto
before look up in the online store.Which issue(s) this PR fixes:
Fixes #1737
Does this PR introduce a user-facing change?: