Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picking documentation fixes from master into 0.12 #1821

Merged
merged 19 commits into from
Sep 1, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 1, 2021

What this PR does / why we need it:
This backports fixes to documentation from master to 0.12. It includes commits from

  1. Gitbook changes:
    git log --no-merges master ^v0.12-branch --grep="GitBook" --reverse

  2. Quickstart python file changes

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1821 (652549a) into v0.12-branch (e6a700d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v0.12-branch    #1821   +/-   ##
=============================================
  Coverage         64.50%   64.50%           
=============================================
  Files                82       82           
  Lines              6196     6196           
=============================================
  Hits               3997     3997           
  Misses             2199     2199           
Flag Coverage Δ
unittests 64.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a700d...652549a. Read the comment docs.

woop and others added 19 commits September 1, 2021 13:48
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
…e prop of Feast (feast-dev#1799)

* Updating quickstart colab to explain more concepts and highlight value prop of Feast

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia removed request for a team, achals and tsotnet September 1, 2021 17:58
docs/README.md Show resolved Hide resolved
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Sep 1, 2021

/lgtm

@woop woop merged commit 06d077c into feast-dev:v0.12-branch Sep 1, 2021
@adchia adchia deleted the v0.12-branch branch September 1, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants