Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing wait interval for BQ integration tests #1827

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 2, 2021

What this PR does / why we need it:
From some quick logging, a hotspot when running integration tests lies in uploading entity_df for BQ related tests. This reduces the polling interval from 10 seconds to 0.1 seconds in test environments (and also reduce the prod environment interval to 1s since the main cost is catching a raised Exception, but there's nothing else happening on this thread)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

… the uploading of the entity_df in integration tests was very slow

Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1827 (befea85) into master (9dc9e60) will decrease coverage by 21.25%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1827       +/-   ##
===========================================
- Coverage   84.60%   63.35%   -21.26%     
===========================================
  Files          94       94               
  Lines        6946     6950        +4     
===========================================
- Hits         5877     4403     -1474     
- Misses       1069     2547     +1478     
Flag Coverage Δ
integrationtests ?
unittests 63.35% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 32.35% <25.00%> (-47.96%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
.../integration/online_store/test_universal_online.py 19.04% <0.00%> (-80.96%) ⬇️
...fline_store/test_universal_historical_retrieval.py 22.09% <0.00%> (-77.91%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...s/integration/registration/test_universal_types.py 31.95% <0.00%> (-68.05%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc9e60...befea85. Read the comment docs.

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 09e0955 into feast-dev:master Sep 3, 2021
@adchia adchia deleted the reduce-bq-test-wait branch September 15, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants