Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace individual cli tests with parametrized tests #1830

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Replace individual cli tests with parametrized tests #1830

merged 2 commits into from
Sep 3, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 3, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

More coverage with fewer test files.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@achals achals requested a review from adchia September 3, 2021 03:54
@achals achals requested review from tsotnet, woop and a team as code owners September 3, 2021 03:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #1830 (f1e71d4) into master (027247d) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
- Coverage   84.31%   84.04%   -0.28%     
==========================================
  Files          93       90       -3     
  Lines        6865     6761     -104     
==========================================
- Hits         5788     5682     -106     
- Misses       1077     1079       +2
Flag Coverage Δ
integrationtests 83.96% <100.00%> (-0.28%) ⬇️
unittests 63.57% <40.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/tests/integration/registration/test_cli.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py 92.85% <0.00%> (-1.79%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 81.37% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027247d...f1e71d4. Read the comment docs.

adchia
adchia reviewed Sep 3, 2021
View reviewed changes
sdk/python/tests/integration/registration/test_cli.py

@pytest.mark.integration
@pytest.mark.parametrize("test_repo_config", FULL_REPO_CONFIGS)
def test_universal_cli(test_repo_config) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_cli_local seems to have a lot of tests that check other commands. Do we want to add them here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added them back.

@achals
Replace individual cli tests with parametrized tests
99395a7 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
port over some tests from test_cli
f1e71d4 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes Sep 3, 2021
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1044745 into feast-dev:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adchia adchia adchia approved these changes

@tsotnet tsotnet Awaiting requested review from tsotnet

@woop woop Awaiting requested review from woop

Assignees

@adchia adchia

Labels
approved kind/housekeeping lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achals @codecov-commenter @feast-ci-bot @adchia