Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer features for on demand feature views, support multiple output features #1845

Merged
merged 13 commits into from
Sep 9, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 8, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Infer features for on demand feature views, support multiple output features 

Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #1845 (bb914b6) into master (b509092) will increase coverage by 0.32%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
+ Coverage   84.52%   84.84%   +0.32%     
==========================================
  Files          90       91       +1     
  Lines        6837     6924      +87     
==========================================
+ Hits         5779     5875      +96     
+ Misses       1058     1049       -9     
Flag Coverage Δ
integrationtests 84.77% <95.83%> (+0.32%) ⬆️
unittests 63.41% <40.83%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fline_store/test_universal_historical_retrieval.py 100.00% <ø> (ø)
sdk/python/feast/type_map.py 81.25% <62.50%> (-1.61%) ⬇️
sdk/python/feast/on_demand_feature_view.py 91.78% <96.00%> (+2.19%) ⬆️
sdk/python/feast/feature_store.py 93.76% <97.14%> (+0.62%) ⬆️
sdk/python/feast/errors.py 69.15% <100.00%> (+1.19%) ⬆️
sdk/python/feast/feature.py 75.00% <100.00%> (ø)
sdk/python/feast/infra/offline_stores/file.py 97.43% <100.00%> (ø)
...python/feast/infra/offline_stores/offline_utils.py 91.20% <100.00%> (+0.09%) ⬆️
sdk/python/feast/infra/provider.py 89.25% <100.00%> (+0.27%) ⬆️
...tegration/feature_repos/universal/feature_views.py 96.00% <100.00%> (+0.16%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b509092...bb914b6. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals changed the title Infer features for on demand feature views Infer features for on demand feature views, support multiple output features Sep 9, 2021
@adchia adchia self-assigned this Sep 9, 2021
@achals achals requested review from adchia and removed request for tsotnet and woop September 9, 2021 16:48
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like there is some weird rebasing that happened re the README

ValueType.DOUBLE: "float",
ValueType.BYTES: "bytes",
ValueType.BOOL: "bool",
ValueType.UNIX_TIMESTAMP: "Timestamp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a pandas type? couldn't find documentation for Timestamp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - I think this is a protobuf type. Fixing.

odfv_feature_refs = defaultdict(list)
for feature_ref in feature_refs:
view_name, feature_name = (
feature_ref.split(":")[0],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: view_name, feature_name = feature_ref.split(":") I tihnk should work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@achals
Copy link
Member Author

achals commented Sep 9, 2021

Nice! Looks like there is some weird rebasing that happened re the README

This is a precommit hook that ran on the README. my guess is that it was added after the README changes were committed and it wasn't run on all existing files.

Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals added kind/feature New feature or request and removed needs-kind labels Sep 9, 2021
@feast-ci-bot feast-ci-bot merged commit 2d52ce7 into feast-dev:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants