Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MVP support for on demand transforms for AWS to_s3 and to_redshift #1856

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 11, 2021

What this PR does / why we need it:
Add MVP support for on demand transforms for AWS to_s3 and to_redshift

Tested with a local repo that uploaded to s3 + to_redshift and inspected results to see on demand transform properly applied into a new column

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #1856 (b25df05) into master (0d0bdf2) will decrease coverage by 0.17%.
The diff coverage is 6.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
- Coverage   85.08%   84.91%   -0.18%     
==========================================
  Files          91       91              
  Lines        7095     7111      +16     
==========================================
+ Hits         6037     6038       +1     
- Misses       1058     1073      +15     
Flag Coverage Δ
integrationtests 84.84% <6.25%> (-0.18%) ⬇️
unittests 62.53% <6.25%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/redshift.py 84.87% <0.00%> (-6.12%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 83.03% <12.50%> (-5.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0bdf2...b25df05. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 6fe086c into feast-dev:master Sep 14, 2021
@adchia adchia deleted the odfv_aws branch September 15, 2021 16:23
@adchia adchia restored the odfv_aws branch September 15, 2021 16:23
@adchia adchia deleted the odfv_aws branch September 15, 2021 16:23
@adchia adchia restored the odfv_aws branch September 15, 2021 16:23
@adchia adchia deleted the odfv_aws branch September 15, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants