Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookup pytest-benchmark to online retreival #1858

Merged
merged 6 commits into from
Sep 16, 2021

Conversation

achals
Copy link
Member

@achals achals commented Sep 14, 2021

What this PR does / why we need it:

This adds benchmarking capability to our test suite:

-------------------------------------------------------------------------------------------------------------- benchmark: 6 tests --------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                  Min                    Max                  Mean                StdDev                Median                   IQR            Outliers      OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_online_retrieval[Provider: local-Fil-sqlite]               9.1365 (1.0)         452.9673 (19.57)       17.1015 (1.04)        54.0603 (18.97)       10.4445 (1.0)          0.8167 (1.0)           1;3  58.4745 (0.96)         67           1
test_online_retrieval[Provider: local-Fil-redis]               12.5955 (1.38)         23.1421 (1.0)         16.4554 (1.0)          2.8490 (1.0)         15.0211 (1.44)         4.6989 (5.75)         20;0  60.7702 (1.0)          68           1
test_online_retrieval[Provider: gcp-BigQuery-redis]            13.7807 (1.51)         34.5902 (1.49)        20.4617 (1.24)         7.3842 (2.59)        15.0223 (1.44)        11.9083 (14.58)        13;0  48.8717 (0.80)         58           1
test_online_retrieval[Provider: aws-Redshif-redis]             14.2859 (1.56)         33.7554 (1.46)        21.1342 (1.28)         7.7164 (2.71)        15.4758 (1.48)        15.1340 (18.53)         8;0  47.3167 (0.78)         31           1
test_online_retrieval[Provider: aws-Redshif-dynamodb]         750.5459 (82.15)       838.0375 (36.21)      800.4803 (48.65)       34.4636 (12.10)      813.1550 (77.86)       49.6590 (60.81)         2;0   1.2492 (0.02)          5           1
test_online_retrieval[Provider: gcp-BigQuery-datastore]     2,992.7181 (327.56)   14,693.6830 (634.93)   5,414.2530 (329.03)   5,187.9380 (>1000.0)  3,160.4443 (302.60)   3,024.1152 (>1000.0)       1;1   0.1847 (0.00)          5           1

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #1858 (87d8f81) into master (77cdc0e) will decrease coverage by 0.54%.
The diff coverage is 51.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   85.13%   84.58%   -0.55%     
==========================================
  Files          92       93       +1     
  Lines        7163     7273     +110     
==========================================
+ Hits         6098     6152      +54     
- Misses       1065     1121      +56     
Flag Coverage Δ
integrationtests 84.55% <51.42%> (-0.53%) ⬇️
unittests 62.42% <51.42%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...marks/test_benchmark_universal_online_retrieval.py 32.00% <32.00%> (ø)
sdk/python/tests/conftest.py 100.00% <100.00%> (ø)
...ts/integration/feature_repos/repo_configuration.py 100.00% <100.00%> (ø)
sdk/python/feast/repo_config.py 82.38% <0.00%> (-10.64%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 84.87% <0.00%> (-6.12%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 83.03% <0.00%> (-5.43%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 78.66% <0.00%> (-3.28%) ⬇️
sdk/python/feast/infra/online_stores/helpers.py 86.20% <0.00%> (-0.46%) ⬇️
sdk/python/feast/errors.py 70.49% <0.00%> (-0.31%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cdc0e...87d8f81. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals requested a review from adchia as a code owner September 16, 2021 00:48
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Sep 16, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit c6bcb46 into feast-dev:master Sep 16, 2021
@achals achals deleted the achal/pytest-benchmark branch September 16, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants