Use contextvars to maintain a call stack during the usage calls #1882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Our usage handling doesn't handle calls to
usage
annotated events within the implementation ofget_online_features
. So, e.g., callingget_feature_views
withinget_online_features
would always get called, which would result in bad performance.This fixes that by maintaining the call stack and making sure any call path that includes
get_online_features
is only sampled.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: