Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list feature format for BigQuery offline datasources. #1889

Merged
merged 7 commits into from
Sep 21, 2021

Conversation

judahrand
Copy link
Member

What this PR does / why we need it:
Should have been using this option from the start but the docs on it are very lacking. Took me an hour or two to find it. This should make BQ behave like the other data store with pyarrow lists instead of the weird {list: {item: value}}.

Some concerns about this being incompatible with already existing tables? Though I think really this is important as the transformation after the fact is slow and this it the 'right' fix.

Which issue(s) this PR fixes:

Fixes #1839

Does this PR introduce a user-facing change?:

Fix list feature format for BigQuery offline datasources. 

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@judahrand judahrand changed the title Bq list Fix list feature format for BigQuery offline datasources. Sep 20, 2021
@adchia
Copy link
Collaborator

adchia commented Sep 20, 2021

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #1889 (f90aa17) into master (1dada6a) will increase coverage by 0.00%.
The diff coverage is 85.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   83.73%   83.74%           
=======================================
  Files          96       96           
  Lines        7353     7363   +10     
=======================================
+ Hits         6157     6166    +9     
- Misses       1196     1197    +1     
Flag Coverage Δ
integrationtests 74.47% <85.29%> (+0.02%) ⬆️
unittests 62.29% <32.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gration/offline_store/test_historical_retrieval.py 97.28% <75.00%> (+0.49%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 79.26% <78.94%> (+0.74%) ⬆️
sdk/python/feast/type_map.py 81.89% <100.00%> (+0.64%) ⬆️
...n/feature_repos/universal/data_sources/bigquery.py 97.61% <100.00%> (-0.06%) ⬇️
...s/integration/registration/test_universal_types.py 100.00% <100.00%> (ø)
sdk/python/tests/utils/data_source_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dada6a...f90aa17. Read the comment docs.

@judahrand
Copy link
Member Author

Not quite there 😢

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand
Copy link
Member Author

All tests passing.

@adchia adchia self-assigned this Sep 21, 2021
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 21f1ef7 into feast-dev:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array/list feature materialization in BQ crashes in type conversion
4 participants