Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concepts/README.md #1926

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Update concepts/README.md #1926

merged 1 commit into from
Oct 7, 2021

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Oct 7, 2021

What this PR does / why we need it:

Screen Shot 2021-10-07 at 9 27 10

The menu bar on the left shows Data source -> Entity -> Feature view but the content on the right shows Data source -> Feature view -> Entity.
Since Data source page says the next page is Entity, I swapped feature-view.md and entity.md.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Yusuke Nishioka <yusuke.nishioka.0713@gmail.com>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, ysk24ok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
Copy link
Collaborator

adchia commented Oct 7, 2021

/ok-to-test

@feast-ci-bot feast-ci-bot merged commit 61b472d into feast-dev:master Oct 7, 2021
@ysk24ok ysk24ok deleted the patch-1 branch October 7, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants