Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add David and Matt as approvers as well #1943

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

achals
Copy link
Member

@achals achals commented Oct 14, 2021

Signed-off-by: Achal Shah achals@gmail.com

Forgot from #1942

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1943 (ef37708) into master (c8e1e47) will decrease coverage by 22.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1943       +/-   ##
===========================================
- Coverage   82.26%   59.38%   -22.89%     
===========================================
  Files          96       96               
  Lines        7669     7669               
===========================================
- Hits         6309     4554     -1755     
- Misses       1360     3115     +1755     
Flag Coverage Δ
integrationtests ?
unittests 59.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 13.74% <0.00%> (-85.50%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 17.14% <0.00%> (-82.15%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 35.41% <0.00%> (-64.59%) ⬇️
...istration/test_universal_odfv_feature_inference.py 35.71% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-63.12%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-62.50%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e1e47...ef37708. Read the comment docs.

@adchia adchia merged commit cd0e0e0 into feast-dev:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants