Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prow configuration for Feast CI #197

Merged
merged 2 commits into from
May 22, 2019
Merged

Update Prow configuration for Feast CI #197

merged 2 commits into from
May 22, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented May 21, 2019

Update Prow configuration to execute Prow jobs for running unit tests and integration tests.

The configuration for the Prow job is in .prow/scripts/config.yaml file.

config-updater plugin has been set up, so changes to .prow/scripts/config.yaml in a pull request will automatically update Prow configuration once it is merged.

There are now 5 required status checks that must pass before pull request can be automatically merged:

  • unit-test-core
  • unit-test-ingestion
  • unit-test-serving
  • unit-test-cli
  • integration-test

Screenshot from 2019-05-22 15-50-03

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-dev feast-dev deleted a comment from feast-ci-bot May 21, 2019
@feast-dev feast-dev deleted a comment from feast-ci-bot May 21, 2019
@feast-dev feast-dev deleted a comment from feast-ci-bot May 21, 2019
@davidheryanto davidheryanto changed the title Pull Request to test Prow behaviour. Please ignore Update Prow configuration for Feast CI May 22, 2019
@budi
Copy link
Contributor

budi commented May 22, 2019

so approving a commit workflow:

  • if contributors are outside of org, admin must check the code before doing /ok-to-test
  • after the tests finished, check if all the jobs are succeeded, and then /lgtm and /approve by the maintainers
  • if all is good, the tide plugin will do the automerge

@pradithya
Copy link
Collaborator

/lgtm Thanks so much @davidheryanto

@zhilingc
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants