Improve performance of _convert_arrow_to_proto

[nossrannug]

What this PR does / why we need it:

_convert_arrow_to_proto does multiple lookups in the list of column
names for the arrow table to find the index of columns. This is done for
each row so the time complexity grows quickly.
Rather than search the list of names for the index we construct a
dictionary {column_name: index}. This allows faster lookups for the
index of a column and speeds up the method significantly which affects
e.g. materialization.

NONE

[feast-ci-bot]

Hi @nossrannug. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[achals]

Thanks! Do you have a sense of the perf gains for this method after this change?

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, nossrannug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nossrannug]

Hey @achals,
I spotted this because I was materializing a feature view containing over 750 columns.
With 100 rows the total time spent in _convert_arrow_to_proto went from 15 sec down to 0.3 sec.

[achals]

Hey @achals,

I spotted this because I was materializing a feature view containing over 750 columns.

With 100 rows the total time spent in _convert_arrow_to_proto went from 15 sec down to 0.3 sec.

That's great!!

[achals]

/lgtm