Always pass full and partial feature names to ODFV

[judahrand]

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:

I've run into a problem where when an ODFV depends on two FV which have colliding feature names the ODFV will always want the full feature names. However, it only gets them when full_feature_names is set when requesting the features.

This PR ensures that both full and partial feature names are always passed to ODFVs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Always pass full and partial feature names to ODFV.

[feast-ci-bot]

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adchia]

/ok-to-test

[codecov-commenter]

Codecov Report

Merging #2003 (2377bfb) into master (963d3ac) will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master    #2003   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         103      103           
  Lines        8396     8398    +2     
=======================================
+ Hits         6973     6975    +2     
  Misses       1423     1423           

Flag	Coverage Δ
integrationtests	74.19% <100.00%> (-0.02%)	⬇️
unittests	60.32% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	87.89% <ø> (ø)
...python/feast/infra/offline_stores/offline_store.py	87.50% <ø> (ø)
sdk/python/feast/transformation_server.py	40.47% <0.00%> (ø)
sdk/python/feast/on_demand_feature_view.py	95.00% <100.00%> (+0.08%)	⬆️
sdk/python/feast/infra/offline_stores/redshift.py	86.99% <0.00%> (-0.82%)	⬇️
sdk/python/feast/infra/offline_stores/file.py	96.80% <0.00%> (-0.80%)	⬇️
sdk/python/feast/infra/offline_stores/bigquery.py	81.39% <0.00%> (-0.59%)	⬇️
sdk/python/feast/infra/online_stores/datastore.py	93.70% <0.00%> (+2.36%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963d3ac...2377bfb. Read the comment docs.

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[judahrand]

This is one approach to solve this issue - the approach which will impact any current users the least. The alternative is to ONLY pass features with full names to ODFVs. This would mean that user's would always have to use such names in the ODFV.

I'm open to thoughts on which is the better approach.