Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Environment timestamps to be in UTC #2007

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Tests have been failing in PT due to timezone issues. This PR fixes those issues.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Copy link
Collaborator Author

/kind bug

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #2007 (00daf12) into master (d35fe44) will increase coverage by 22.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2007       +/-   ##
===========================================
+ Coverage   60.35%   83.21%   +22.85%     
===========================================
  Files         103      103               
  Lines        8417     8417               
===========================================
+ Hits         5080     7004     +1924     
+ Misses       3337     1413     -1924     
Flag Coverage Δ
integrationtests 74.37% <ø> (?)
unittests 60.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 93.82% <ø> (+41.97%) ⬆️
sdk/python/feast/online_response.py 86.79% <0.00%> (+1.88%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 72.72% <0.00%> (+3.03%) ⬆️
sdk/python/feast/repo_config.py 78.97% <0.00%> (+3.97%) ⬆️
sdk/python/feast/infra/provider.py 90.90% <0.00%> (+4.13%) ⬆️
sdk/python/feast/errors.py 70.00% <0.00%> (+5.00%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+6.45%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/flags_helper.py 90.47% <0.00%> (+9.52%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35fe44...00daf12. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@adchia
Copy link
Collaborator

adchia commented Nov 10, 2021

/lgtm

@adchia adchia merged commit cbe45a0 into feast-dev:master Nov 10, 2021
@adchia
Copy link
Collaborator

adchia commented Nov 10, 2021

force merged since over two runs of the integration tests, different python versions flaked out each time (but all tests pass at least once over the two runs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants