-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checked out branch for PR docker image build workflow #2018
Fix checked out branch for PR docker image build workflow #2018
Conversation
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
===========================================
- Coverage 83.22% 60.34% -22.88%
===========================================
Files 103 103
Lines 8421 8421
===========================================
- Hits 7008 5082 -1926
- Misses 1413 3339 +1926
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind housekeeping |
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Looks like by default docker image build & push step checks out master branch, which is not what we want. Instead, we want to check out the PR branch and build the docker image from that codebase.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: