-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported java parts #2029
Conversation
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2029 +/- ##
===========================================
- Coverage 83.23% 60.34% -22.89%
===========================================
Files 103 103
Lines 8421 8421
===========================================
- Hits 7009 5082 -1927
- Misses 1412 3339 +1927
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@@ -1,154 +0,0 @@ | |||
# replicaCount -- Number of pods that will be created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving a comment here but letting this merge to fix test. We might want to consider having charts, etc within the java subdirectory since there is an analagous sdk/python/feast/infra directory. Could see it going either way though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
<artifactId>feast-common</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<!-- <dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this can just be removed? but letting merge since it also fixes tests
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex moskalenko.alexey@gmail.com
What this PR does / why we need it:
This PR refactors java code in accordance with Feast roadmap:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: