-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make feast registry-dump
print the whole registry as one json
#2040
Make feast registry-dump
print the whole registry as one json
#2040
Conversation
Signed-off-by: Gunnar Sv Sigurbjörnsson <gunnar.sigurbjornsson@gmail.com>
Hi @nossrannug. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
- Coverage 60.01% 57.47% -2.55%
==========================================
Files 103 100 -3
Lines 8523 8044 -479
==========================================
- Hits 5115 4623 -492
- Misses 3408 3421 +13
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@nossrannug can you please describe the change (before / after)? |
Hey @woop, I've updated the top comment to include the before and after json blobs |
Looks good to me. I think we should also print a warning that the |
it is for debugging only and should not be relied on. Signed-off-by: Gunnar Sv Sigurbjörnsson <gunnar.sigurbjornsson@gmail.com>
Added this message to the output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, nossrannug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind housekeeping |
What this PR does / why we need it:
When running
feast registry-dump
, the whole registry is printed as one json.I intentionally kept all the logic in repo_operations.py instead of adding a method to the Registry class since this is for debugging only.
Changes
The current implementation will print the json representation of each entity and feature view but none of the other objects such as feature services and on demand feature views. It is also not obvious which type each json represents.
The change in this PR would print one json object containing a list of all objects of the registry.
The json object will contain entities, featureViews, featureTables, featureServices, onDemandFeatureViews, and requestFeatureViews.