Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo enabling on_demand_transforms #2044

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

ArrichM
Copy link
Contributor

@ArrichM ArrichM commented Nov 16, 2021

Fixing typo: The correct CLI command is 'feast alpha enable on_demand_transforms' - not 'feast alpha enable enable_on_demand_transforms'

What this PR does / why we need it:
Fixes a typo in the docs.

Does this PR introduce a user-facing change?:
NONE

@feast-ci-bot
Copy link
Collaborator

Hi @ArrichM. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #2044 (18b7971) into master (dc46a96) will decrease coverage by 3.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   83.70%   80.65%   -3.06%     
==========================================
  Files         100      100              
  Lines        8028     8706     +678     
==========================================
+ Hits         6720     7022     +302     
- Misses       1308     1684     +376     
Flag Coverage Δ
integrationtests 73.43% <ø> (-1.03%) ⬇️
unittests 57.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/tests/integration/registration/test_registry.py 57.32% <0.00%> (-42.68%) ⬇️
...n/tests/integration/registration/test_inference.py 75.60% <0.00%> (-24.40%) ⬇️
...sts/integration/registration/test_feature_store.py 75.50% <0.00%> (-23.82%) ⬇️
...python/tests/integration/e2e/test_universal_e2e.py 66.17% <0.00%> (-21.83%) ⬇️
sdk/python/feast/infra/aws.py 72.59% <0.00%> (-11.06%) ⬇️
sdk/python/feast/repo_operations.py 37.92% <0.00%> (-6.04%) ⬇️
sdk/python/feast/feature_store.py 84.94% <0.00%> (-5.50%) ⬇️
sdk/python/feast/feature_view.py 85.58% <0.00%> (-2.47%) ⬇️
sdk/python/feast/feature.py 70.40% <0.00%> (-2.32%) ⬇️
sdk/python/feast/inference.py 87.50% <0.00%> (-2.30%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc46a96...18b7971. Read the comment docs.

@felixwang9817
Copy link
Collaborator

hey @ArrichM, thanks for the PR! in order to pass the DCO test, you'll need to rebase and sign your commit

…_transforms' - not 'feast alpha enable enable_on_demand_transforms'

Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArrichM, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

/kind housekeeping

@felixwang9817
Copy link
Collaborator

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants