-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing typo enabling on_demand_transforms #2044
Conversation
Hi @ArrichM. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 83.70% 80.65% -3.06%
==========================================
Files 100 100
Lines 8028 8706 +678
==========================================
+ Hits 6720 7022 +302
- Misses 1308 1684 +376
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hey @ArrichM, thanks for the PR! in order to pass the DCO test, you'll need to rebase and sign your commit |
…_transforms' - not 'feast alpha enable enable_on_demand_transforms' Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArrichM, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind housekeeping |
/ok-to-test |
Fixing typo: The correct CLI command is 'feast alpha enable on_demand_transforms' - not 'feast alpha enable enable_on_demand_transforms'
What this PR does / why we need it:
Fixes a typo in the docs.
Does this PR introduce a user-facing change?:
NONE