Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed error messages for test_univerisal_e2e failures #2062

Merged

Conversation

achals
Copy link
Member

@achals achals commented Nov 18, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

There's some flakiness in this error and I can't figure out why - hoping that additional context will help debug.

Does this PR introduce a user-facing change?:

none

Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #2062 (192eacb) into master (8f370a0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2062   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files         100      100           
  Lines        8080     8080           
=======================================
  Hits         4706     4706           
  Misses       3374     3374           
Flag Coverage Δ
unittests 58.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/tests/integration/e2e/test_universal_e2e.py 30.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f370a0...192eacb. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Nov 18, 2021

/lgtm

@achals
Copy link
Member Author

achals commented Nov 18, 2021

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit f5c1935 into feast-dev:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants