Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using cached registry when writing to the online store #2066

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

achals
Copy link
Member

@achals achals commented Nov 18, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2051

Does this PR introduce a user-facing change?:

Use cached registry to speed up direct writes to the online store

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #2066 (e51fe64) into master (f2f5dc6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2066   +/-   ##
=======================================
  Coverage   58.21%   58.22%           
=======================================
  Files         100      100           
  Lines        8078     8076    -2     
=======================================
- Hits         4703     4702    -1     
+ Misses       3375     3374    -1     
Flag Coverage Δ
unittests 58.22% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 70.88% <0.00%> (ø)
sdk/python/feast/registry.py 70.27% <100.00%> (ø)
sdk/python/tests/conftest.py 68.83% <0.00%> (-1.30%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 32.80% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f5dc6...e51fe64. Read the comment docs.

@feast-ci-bot feast-ci-bot removed the lgtm label Nov 18, 2021
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@felixwang9817
Copy link
Collaborator

/lgtm

@felixwang9817
Copy link
Collaborator

/kind housekeeping

@feast-ci-bot feast-ci-bot merged commit 9d84178 into feast-dev:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make direct data ingestion into online store faster
5 participants