Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken entity key link in quickstart #2068

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Nov 18, 2021

What this PR does / why we need it:
Fixes a broken link in the quickstart python notebook

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #2068 (44c24ee) into master (380cc62) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   83.59%   83.31%   -0.29%     
==========================================
  Files         100      100              
  Lines        8084     8084              
==========================================
- Hits         6758     6735      -23     
- Misses       1326     1349      +23     
Flag Coverage Δ
integrationtests 73.74% <ø> (+0.02%) ⬆️
unittests 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 72.59% <0.00%> (-11.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380cc62...44c24ee. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Nov 18, 2021

/lgtm

@achals
Copy link
Member

achals commented Nov 19, 2021

@adchia I think this needs to be rebased before it can get merged

Signed-off-by: Danny Chiao <danny@tecton.ai>
@achals
Copy link
Member

achals commented Nov 23, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit c239037 into feast-dev:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants