-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in feature retrieval doc #2092
Conversation
Hi @olivierlabreche. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 100 100
Lines 8077 8077
=======================================
Hits 6740 6740
Misses 1337 1337
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hey @olivierlabreche, thanks a lot for the PR! We require that all commits be signed - would you mind rebasing your changes and signing all of your commits? Thanks! |
Signed-off-by: Olivier Labreche <olivier.labreche@shopify.com>
78dcb1b
to
09c866d
Compare
Sign-off added. Thanks. |
/assign @felixwang9817 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817, olivierlabreche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fix a typo (I think) in feature retrieval doc. I am not sure why we talk about "entity timestamp" when we refer to "event timestamp" everywhere else in the paragraph.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?:
NONE