Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spring-boot from the feast serving application #2127

Merged
merged 7 commits into from
Dec 29, 2021

Conversation

achals
Copy link
Member

@achals achals commented Dec 9, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Removes spring-boot from the feast serving application

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #2127 (9a56204) into master (a710cb9) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
+ Coverage   84.39%   84.59%   +0.19%     
==========================================
  Files         101      102       +1     
  Lines        8133     8186      +53     
==========================================
+ Hits         6864     6925      +61     
+ Misses       1269     1261       -8     
Flag Coverage Δ
integrationtests 74.24% <ø> (-0.45%) ⬇️
unittests 59.01% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/provider.py 89.90% <0.00%> (-0.75%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 87.82% <0.00%> (-0.41%) ⬇️
sdk/python/feast/utils.py 100.00% <0.00%> (ø)
sdk/python/feast/on_demand_feature_view.py 99.21% <0.00%> (ø)
...n/tests/integration/registration/test_inference.py 100.00% <0.00%> (ø)
sdk/python/tests/unit/diff/test_fco_diff.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 98.13% <0.00%> (+0.46%) ⬆️
sdk/python/feast/infra/offline_stores/redshift.py 88.57% <0.00%> (+0.47%) ⬆️
...python/feast/infra/offline_stores/offline_utils.py 92.07% <0.00%> (+0.58%) ⬆️
sdk/python/feast/type_map.py 73.17% <0.00%> (+0.63%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a710cb9...9a56204. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Dec 29, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 068389d into feast-dev:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants