Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tag methods to infer created, deleted, and kept repo objects #2142

Merged
merged 7 commits into from
Dec 15, 2021

Conversation

achals
Copy link
Member

@achals achals commented Dec 14, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

This is a first PR to support the feast plan command, as it applies to FCOs. It also adds a diff_betewen method for Registry objects, which is not complete in its implementation at this point.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

…kept

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals added the kind/feature New feature or request label Dec 14, 2021
@achals achals requested a review from a team as a code owner December 14, 2021 09:23
@achals achals requested review from adchia and removed request for a team December 14, 2021 09:23
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
sdk/python/feast/diff/FcoDiff.py Outdated Show resolved Hide resolved
sdk/python/feast/diff/FcoDiff.py Outdated Show resolved Hide resolved
)

@classmethod
def from_proto(cls, regsitry_proto: RegistryProto):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: regsitry is mispelled

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: why do we need a from_proto for the registry? I thought the registry contents would always be persisted by the registry store

to clarify, even when we want to compare two registries, we will be comparing protos; I don't think we'll need to reconstruct a registry from a proto?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah fair, I can change this to operate on the protos themselves. I think I misunderstood earlier

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #2142 (2de2d29) into master (5560caf) will increase coverage by 25.45%.
The diff coverage is 56.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2142       +/-   ##
===========================================
+ Coverage   57.88%   83.34%   +25.45%     
===========================================
  Files         101      102        +1     
  Lines        8176     8213       +37     
===========================================
+ Hits         4733     6845     +2112     
+ Misses       3443     1368     -2075     
Flag Coverage Δ
integrationtests 73.54% <55.10%> (?)
unittests 58.11% <56.43%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 48.41% <19.23%> (+4.23%) ⬆️
sdk/python/feast/registry.py 78.86% <59.09%> (+11.53%) ⬆️
sdk/python/feast/diff/FcoDiff.py 71.42% <71.42%> (ø)
sdk/python/feast/feature_store.py 90.26% <100.00%> (+20.03%) ⬆️
sdk/python/feast/feature_view.py 89.43% <100.00%> (+12.29%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 72.72% <0.00%> (+3.03%) ⬆️
sdk/python/feast/errors.py 70.00% <0.00%> (+5.00%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5560caf...2de2d29. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants