Avoid requesting features from OnlineStore twice #2185
Conversation
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
+ Coverage 84.57% 84.59% +0.02%
==========================================
Files 102 102
Lines 8195 8207 +12
==========================================
+ Hits 6931 6943 +12
Misses 1264 1264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdk/python/feast/feature_store.py
Outdated
| table_join_keys = [ | ||
| entity_name_to_join_key_map[entity_name] | ||
| for entity_name in fv.entities | ||
| feature_deps = [ |
There was a problem hiding this comment.
Trying to follow this code I'm confused what feature_deps means here and what this block of code does.. Any possibility to rename/refactor/add comments?
There was a problem hiding this comment.
Had another pass at this and caught a case I hadn't considered + added some comments etc. More clear now?
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2184
Does this PR introduce a user-facing change?: