-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare only specs in integration tests #2200
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the test to only compare the specs instead? Would be easier
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
===========================================
+ Coverage 58.97% 84.62% +25.65%
===========================================
Files 104 104
Lines 8270 8272 +2
===========================================
+ Hits 4877 7000 +2123
+ Misses 3393 1272 -2121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: #1952 was recently merged and is currently breaking integration tests on master. Specifically, by setting
created_timestamp
for feature views, thetest_universal_cli
test breaks because the secondfeast apply
changes FV metadata, causing the registry to be changed. This PR ensures that when registry contents are compared after the first and second calls tofeast plan
, only specs of the FCOs are compared, and metadata is excluded. This allows the test to pass.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: